Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: allow disable SearchKeywordUpdater#15475

Merged
Vin Le (vienthuong) merged 9 commits into
trunkfrom
15470-opt-in-parameter-to-disable-search-keyword-updater
Mar 30, 2026
Merged

feat: allow disable SearchKeywordUpdater#15475
Vin Le (vienthuong) merged 9 commits into
trunkfrom
15470-opt-in-parameter-to-disable-search-keyword-updater

Conversation

@vienthuong
Copy link
Copy Markdown
Contributor

@vienthuong Vin Le (vienthuong) commented Mar 11, 2026 •
edited
Loading

Solves #15470

@vienthuong Vin Le (vienthuong) linked an issue Mar 11, 2026 that may be closed by this pull request
Opt-in parameter to disable search keyword updater #15470
Closed
@vienthuong Vin Le (vienthuong) self-assigned this Mar 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 11, 2026

Warnings
⚠️ You updated the shopware.yaml, please consider to update the config-schema.json
⚠️ Please be kind and add unit tests for your new code in these files:

src/Elasticsearch/Resources/config/packages/shopware.php

If you are sure everything is fine with your changes, you can resolve this warning.
You can run `composer make:coverage` to generate dummy unit tests for files that are not covered

@explore-openapi
Copy link
Copy Markdown

explore-openapi Bot commented Mar 11, 2026 •
edited
Loading

OpenAPI Snapshot

ℹ️ shopware/store-api — schema identical to base trunk

📋 Additional Information

⚠️ Changes are matching an older version of the schema. Update the branch to make sure that the schema diff is correct.

ℹ️ shopware/admin-api — schema identical to base trunk

📋 Additional Information

⚠️ Changes are matching an older version of the schema. Update the branch to make sure that the schema diff is correct.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.64286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.37%. Comparing base (37f18df) to head (4b205de).
⚠️ Report is 16 commits behind head on trunk.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...Elasticsearch/Product/SearchKeywordReplacement.php 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk   #15475      +/-   ##
==========================================
+ Coverage   58.31%   58.37%   +0.05%     
==========================================
  Files        3060     3061       +1     
  Lines       95961    96003      +42     
==========================================
+ Hits        55964    56045      +81     
+ Misses      39997    39958      -39
Flag Coverage Δ
phpunit-migration 92.40% <ø> (ø)
phpunit-unit 55.30% <94.64%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vienthuong Vin Le (vienthuong) force-pushed the 15470-opt-in-parameter-to-disable-search-keyword-updater branch 5 times, most recently from e9f3468 to 636977d Compare March 11, 2026 16:33
@github-actions github-actions Bot added the needs-triage A newly created issue or PR that needs team assignment and/or prioritization. label Mar 12, 2026
@vienthuong Vin Le (vienthuong) added domain/inventory Responsible for managing products and everything product-related and removed needs-triage A newly created issue or PR that needs team assignment and/or prioritization. labels Mar 12, 2026
@vienthuong Vin Le (vienthuong) force-pushed the 15470-opt-in-parameter-to-disable-search-keyword-updater branch from 636977d to 7b63a6b Compare March 18, 2026 14:43
@vienthuong Vin Le (vienthuong) marked this pull request as ready for review March 18, 2026 14:46
rittou
Phung Nguyen (rittou) reviewed Mar 19, 2026
View reviewed changes
Comment thread src/Core/Content/Product/DataAbstractionLayer/SearchKeywordUpdater.php Outdated
mitelg
Michael Telgmann (mitelg) requested changes Mar 26, 2026
View reviewed changes
Comment thread src/Elasticsearch/Resources/config/packages/shopware.php Outdated
Comment thread UPGRADE-6.8.md Outdated
Comment thread RELEASE_INFO-6.7.md Outdated
@vienthuong
Merge branch 'trunk' of github.com:shopware/shopware into 15470-opt-i…
13de130 
…n-parameter-to-disable-search-keyword-updater
@vienthuong
chore: update REALEASE_INFO
90565f7
@vienthuong
Merge branch '15470-opt-in-parameter-to-disable-search-keyword-update…
75d99be 
…r' of github.com:shopware/shopware into 15470-opt-in-parameter-to-disable-search-keyword-updater
@vienthuong Vin Le (vienthuong) added this pull request to the merge queue Mar 30, 2026
Merged via the queue into trunk with commit b4af106 Mar 30, 2026
68 checks passed
@vienthuong Vin Le (vienthuong) deleted the 15470-opt-in-parameter-to-disable-search-keyword-updater branch March 30, 2026 08:27
@github-actions github-actions Bot added this to the 6.7.9.0 milestone Mar 30, 2026
Florian Robel (frobel) pushed a commit that referenced this pull request Apr 8, 2026
@vienthuong @frobel
feat: allow disable SearchKeywordUpdater (#15475)
b58f1da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mitelg Michael Telgmann (mitelg) mitelg approved these changes

@tamvt Tam Vo (tamvt) tamvt approved these changes

@rittou Phung Nguyen (rittou) rittou approved these changes

@keulinho Jonas Elfering (keulinho) Awaiting requested review from keulinho

Assignees

@vienthuong Vin Le (vienthuong)

Labels

domain/inventory Responsible for managing products and everything product-related milestone/6.7.9.0

Projects

None yet

Milestone

6.7.9.0

Development

Successfully merging this pull request may close these issues.

Opt-in parameter to disable search keyword updater

4 participants

@vienthuong @mitelg @tamvt @rittou