Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: digital products are not downloadable on storefront (backport: 6.7.8.x)#15614

Merged
Vin Le (vienthuong) merged 2 commits into
6.7.8.xfrom
15520-digital-products-downloadaccess-not-possible-backport-6.7.8.x
Mar 17, 2026
Merged

fix: digital products are not downloadable on storefront (backport: 6.7.8.x)#15614
Vin Le (vienthuong) merged 2 commits into
6.7.8.xfrom
15520-digital-products-downloadaccess-not-possible-backport-6.7.8.x

Conversation

@shopware-octo-sts-app-2
Copy link
Copy Markdown
Contributor

@shopware-octo-sts-app-2 shopware-octo-sts-app-2 Bot commented Mar 16, 2026

Backport: #15563
Resolves: #15520

  • Identified the regression in 6.7.8.0 caused by product-type introduction: download flow still relied on deprecated productState matching.
  • Added migration 1773392534 to migrate rule conditions from cartLineItemProductStates (is-download) to cartLineItemProductType (digital).
  • Registered rule.indexer in that migration so updated rules are re-indexed immediately.
  • Added migration 1773392535 to backfill order_line_item_download.access_granted = 1 for already paid orders containing digital line items.
  • Kept the change targeted and backward-safe by only updating rows that match the exact paid + digital criteria.
  • Added migration tests in tests/migration/Core/V6_7 for both migrations, including idempotency and positive/negative cases.

@shopware-octo-sts-app-2 shopware-octo-sts-app-2 Bot added the domain/inventory Responsible for managing products and everything product-related label Mar 16, 2026
@shopware-octo-sts-app-2 shopware-octo-sts-app-2 Bot added the domain/inventory Responsible for managing products and everything product-related label Mar 16, 2026
@github-actions github-actions Bot added external-contribution A PR contributed by a community member. milestone/6.7.8.2 labels Mar 16, 2026
@explore-openapi
Copy link
Copy Markdown

explore-openapi Bot commented Mar 16, 2026 •
edited
Loading

OpenAPI Snapshot

ℹ️ shopware/store-api — schema identical to base trunk

📋 Additional Information

⚠️ Changes are matching an older version of the schema. Update the branch to make sure that the schema diff is correct.

⚠️ shopware/admin-api — base 6.7.8.x — 27 changes (9 removals · 18 modifications)

Diff: https://explore-openapi.dev/diff#...

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.08333% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (6.7.8.x@3431629). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ubscriber/RepairDigitalProductStatesSubscriber.php 82.22% 8 Missing ⚠️
...ent/Product/DataAbstractionLayer/StatesUpdater.php 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             6.7.8.x   #15614   +/-   ##
==========================================
  Coverage           ?   56.61%           
==========================================
  Files              ?     3002           
  Lines              ?    92515           
  Branches           ?        0           
==========================================
  Hits               ?    52381           
  Misses             ?    40134           
  Partials           ?        0
Flag Coverage Δ
phpunit-migration 91.81% <ø> (?)
phpunit-unit 54.03% <77.08%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

keulinho
Jonas Elfering (keulinho) reviewed Mar 16, 2026
View reviewed changes
Comment thread UPGRADE-6.7.md Outdated
@ngocblue ngocblue self-requested a review March 17, 2026 04:23
ngocblue
ngocblue approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown

@ngocblue ngocblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Passed

  • "Download" button displays after purchasing Digital Product and product is paid.
  • Run migration bin/console system:update:finish then Product with states is NULL is updated to ["is-download"] + key 'core.repaired_digital_product_states' is added with value = 1

@vienthuong Vin Le (vienthuong) merged commit 950e0a0 into 6.7.8.x Mar 17, 2026
98 of 100 checks passed
@vienthuong Vin Le (vienthuong) deleted the 15520-digital-products-downloadaccess-not-possible-backport-6.7.8.x branch March 17, 2026 04:30
@github-actions github-actions Bot added this to the 6.7.8.2 milestone Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keulinho Jonas Elfering (keulinho) keulinho approved these changes

@ngocblue ngocblue ngocblue approved these changes

@vienthuong Vin Le (vienthuong) Awaiting requested review from vienthuong

@mkraeml Marcel Kräml (mkraeml) Awaiting requested review from mkraeml

Assignees

@vienthuong Vin Le (vienthuong)

Labels

domain/inventory Responsible for managing products and everything product-related external-contribution A PR contributed by a community member. milestone/6.7.8.2

Projects

None yet

Milestone

6.7.8.2

Development

Successfully merging this pull request may close these issues.

3 participants

@keulinho @vienthuong @ngocblue