test: migrate field serializer coverage to unit tests#16759
Open
Jonas Elfering (keulinho) wants to merge 5 commits into
Open
test: migrate field serializer coverage to unit tests#16759Jonas Elfering (keulinho) wants to merge 5 commits into
Jonas Elfering (keulinho) wants to merge 5 commits into
Conversation
|
OpenAPI Snapshotℹ️ shopware/store-api — schema identical to base trunkℹ️ shopware/admin-api — schema identical to base trunk📋 Additional Information |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #16759 +/- ##
==========================================
+ Coverage 62.28% 62.37% +0.09%
==========================================
Files 4834 4836 +2
Lines 175922 175992 +70
Branches 9989 9989
==========================================
+ Hits 109568 109773 +205
+ Misses 63415 63280 -135
Partials 2939 2939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nicolas Fortier (nfortier-shopware)
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Some field serializer coverage lived in integration tests even though the behavior can be tested directly with focused unit tests. Moving this low-level behavior into unit tests improves coverage in the faster suite and reduces integration test scope.
2. What does this change do, exactly?
Moves pure field serializer and related field behavior coverage into unit tests, trims duplicated integration coverage, and keeps only smoke coverage where repository/service wiring still matters.
It also refactors the int and string field serializer unit tests into smaller, readable scenarios. The string serializer test now folds create/update assertions into each scenario so providers only describe the actual value and flag behavior.
3. Describe each step to reproduce the issue or behaviour.
Run the affected field serializer unit tests and compare them with the removed integration-only coverage.
4. Please link to the relevant issues (if any).
5. Checklist
RELEASE_INFO-6.<major>.mdunder “Upcoming” for informational changes, including the consequences of the change and how it affects external developers.UPGRADEsection inUPGRADE-6.<next-major>.mdfor breaking changes (what/why/impact/how to adapt).