Adds support for Redis URIs #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds simple test case for creating a lock with the URI constructor.
|
Hey @siahsang! This PR is stalled for a while... Anything in the implementation that should be different? You don't find this functionality interesting? I'd love to hear your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
First of all, thanks for developing and sharing this library, it is helping us out in using distributed locks 👍
I just updated your code so that it supports Redis URIs, namely in this format:
redis://myUser:myPassword@host:9178/Let me know if you agree with the changes or if you would do something differently to support these URIs.