-
Notifications
You must be signed in to change notification settings - Fork 0
Membership Payment Form Redesign #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already have an issue here, in the current web on master, if the person provides no keys, the page loads fine - in this version, without keys, the page crashes. Please fix. I should not need keys to open the page, nor to open the payment form, but only to submit without an issue and that issue should be handled on the front end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality:
- Scrolling is still enabled while the popup is on the screen, which may or may not make sense
- Due to scrolling, text on the hero is on top of the popout, use z-index to fix this
Style:
- The hover effect for the button opening the popup is gaudy and obscene, compare to the other page buttons
- We had discussed putting some information about what they were purchasing on the card that pops up, remember, this feature is mainly about making it easier to trust this - we may also want to put a "Powered by Stripe" note on the popout
- review button also needs to get better treatment
- dollar sign after dollars is weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
06fa377
to
94faa72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Checklist: