Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

KerimD
Copy link
Contributor

@KerimD KerimD commented Aug 22, 2020

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ClayMav ClayMav changed the title feature/payment-form updated payment form to include review slide and Membership Payment Form Redesign Sep 5, 2020
Copy link
Contributor

@ClayMav ClayMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already have an issue here, in the current web on master, if the person provides no keys, the page loads fine - in this version, without keys, the page crashes. Please fix. I should not need keys to open the page, nor to open the payment form, but only to submit without an issue and that issue should be handled on the front end

Copy link
Contributor

@ClayMav ClayMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality:

  • Scrolling is still enabled while the popup is on the screen, which may or may not make sense
  • Due to scrolling, text on the hero is on top of the popout, use z-index to fix this

Screen Shot 2020-11-15 at 02 45 36

- using the authentication required card does not actually apply the membership as expected. as seen at [https://stripe.com/docs/testing](https://stripe.com/docs/testing)

Style:

  • The hover effect for the button opening the popup is gaudy and obscene, compare to the other page buttons
  • We had discussed putting some information about what they were purchasing on the card that pops up, remember, this feature is mainly about making it easier to trust this - we may also want to put a "Powered by Stripe" note on the popout
  • review button also needs to get better treatment
  • dollar sign after dollars is weird

Screen Shot 2020-11-15 at 02 51 49

- this info seems kind of useless without context, also is this sent to them in email or anything? Any way they can get this if they dont save it now?

Screen Shot 2020-11-15 at 02 52 23

@ClayMav ClayMav requested a review from cjwagn1 December 15, 2020 01:33
Copy link
Contributor

@cjwagn1 cjwagn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make mobile-friendly:

image

@cjwagn1 cjwagn1 self-requested a review March 2, 2021 02:57
Copy link
Contributor

@cjwagn1 cjwagn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Needs to fix up a bit of squishing on the card number and expiration date.

Example 1:
image

Example 2:
image

Once that and the powered by stripe CDN image is up, then this should be good to go.

@cjwagn1 cjwagn1 self-requested a review March 31, 2021 01:47
@KerimD KerimD force-pushed the feature/payment-form branch from 06fa377 to 94faa72 Compare April 5, 2021 19:29
Copy link
Contributor

@cjwagn1 cjwagn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cjwagn1 cjwagn1 dismissed ClayMav’s stale review April 6, 2021 00:03

clay outa here

@KerimD KerimD merged commit d3872ac into master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants