Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/membership tool rework #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 11, 2022
Merged

Feature/membership tool rework #361

merged 16 commits into from
Feb 11, 2022

Conversation

henrievjen
Copy link
Contributor

@henrievjen henrievjen commented Nov 2, 2021 •
edited by cjwagn1
Loading

  • Reduced number of messages popping up
  • Expiration date no longer goes back one day before selected date
  • Added color to status entries
  • Shirt column is now checkbox
  • Ability to lock and unlock shirt column
  • Any edits save immediately
  • Edit and Delete buttons in dropdown menu
  • Names that are empty no longer display as "null null"

Pull Request Description

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
    closes Membership Tool Rework #254

@henrievjen henrievjen requested a review from cjwagn1 November 2, 2021 16:18
cjwagn1
cjwagn1 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@cjwagn1 cjwagn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mastercard developers are 11/10

@cjwagn1 cjwagn1 merged commit 47caedd into master Feb 11, 2022
@cjwagn1 cjwagn1 deleted the feature/membership-tool-rework branch February 11, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@cjwagn1 cjwagn1 cjwagn1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Membership Tool Rework
2 participants
@henrievjen @cjwagn1