Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for ed25519 keys #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support for ed25519 keys #1377

wants to merge 6 commits into from

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented May 9, 2025 •
edited
Loading

Client support for Rekor V2: sigstore-python

Summary

Resolves #1376, #1378

Adds support for ed25519 keys. In the cryptography library, is not yet any support for ed25519ph operations.

Fixes the CI test for timestamp-authority to use the latest release, not the latest tag, since we could have new tags without associated release artifacts to download.

Release Note

  • Added support for ed25519 keys.
  • CI: Timestamp Authority tests use latest release, not latest tag, of
    sigstore/timestamp-authority

Documentation

None

@ramonpetgrave64
add support for ed25519 keys
8e4c394 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64
Merge branch 'main' into ed25519
d03cb47 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64
add changelog self link
ee73bb4 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as draft May 9, 2025 16:40
@ramonpetgrave64
lint
dad8ff6 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64
use latest tsa release, not latest tag
95d6e11 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64
add changelog for tsa test fix
da72b8a 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review May 9, 2025 20:16
@ramonpetgrave64
Copy link
Contributor Author

@woodruffw @jku

@ramonpetgrave64 ramonpetgrave64 mentioned this pull request May 7, 2025
Open
27 tasks
@jku
Copy link
Member

jku commented May 10, 2025 •
edited
Loading

LGTM. Getting this tested should be easy... I don't think there is any problem just editing the trusted_root/trustedroot.v1.json asset and making sure one of the keys is ed25519 (you could add a new log instance for example) -- the test only tests loading the key but it's better than nothing

jku
jku requested changes May 12, 2025
View reviewed changes
Copy link
Member

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking "request changes" for the test: let me know if it seems to not be straight forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jku jku jku requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ed25519 keys
2 participants
@ramonpetgrave64 @jku