Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: move almost everything to pyproject.toml #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2022

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented May 3, 2022

This requires a MANIFEST.in, since setuptools apparently
can't specify package data in pyproject.toml. Yet.

Closes #69.

@woodruffw woodruffw added the refactoring Refactoring tasks. label May 3, 2022
@woodruffw woodruffw requested review from di and tetsuo-cpp May 3, 2022 15:50
@woodruffw woodruffw self-assigned this May 3, 2022
This requires a `MANIFEST.in`, since `setuptools` apparently
can't specify package data in `pyproject.toml`. Yet.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw force-pushed the ww/pyproject-for-build branch from 1786092 to a661d5f Compare May 3, 2022 15:51
woodruffw added 2 commits May 3, 2022 09:55
I was wrong!

Signed-off-by: William Woodruff <[email protected]>
sigstore uses click, so this isn't relevant.

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: Alex Cameron <[email protected]>
@tetsuo-cpp tetsuo-cpp force-pushed the ww/pyproject-for-build branch from 1bd220c to 2dfd0fd Compare May 5, 2022 06:42
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit 2178a1c into main May 5, 2022
@tetsuo-cpp tetsuo-cpp deleted the ww/pyproject-for-build branch May 5, 2022 06:44
javanlacerda pushed a commit to javanlacerda/sigstore-python that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace setup.py with metadata in pyproject.toml
2 participants