Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

u-kai
Copy link
Contributor

@u-kai u-kai commented Jan 25, 2025

ecs-deploy is in maintenance mode, but this change is backward-compatible and addresses a necessary use case by enabling support for container images with digests.

I would appreciate it if you could consider merging it.

Added

  • Support container image with digest.
  • Add tests for container image with digest.

Related issues

#294


Feature PR Checklist

  • Documentation (README, local.env.dist, etc.)
  • Unit tests created or updated (see test.bats file)

@forevermatt
Copy link
Contributor

Hi @u-kai. Thank you for your PR. We'll take a look and let you know, but my first impression is that this looks promising.

@devon-sil devon-sil requested a review from a team January 30, 2025 14:23
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, thank you, @u-kai! I only have one minor suggestion to give.

@briskt briskt merged commit 03cbf76 into sil-org:master Jan 31, 2025
@u-kai
Copy link
Contributor Author

u-kai commented Jan 31, 2025

@forevermatt @briskt
Thank you for reviewing and merging! That really helped!

@u-kai u-kai deleted the support-digest branch January 31, 2025 12:39
@briskt
Copy link
Contributor

briskt commented Feb 1, 2025

@forevermatt @briskt Thank you for reviewing and merging! That really helped!

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants