[Data Cleanup] Redesign goal options/history page#3836
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3836 +/- ##
==========================================
- Coverage 74.27% 65.71% -8.56%
==========================================
Files 287 237 -50
Lines 10653 6044 -4609
Branches 1327 756 -571
==========================================
- Hits 7912 3972 -3940
+ Misses 2355 1823 -532
+ Partials 386 249 -137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
I think we might want to consider some 'small' adjustments to the GoalHistoryButton in the future, but I won't hold off this PR for those. It all looks well put together and a good overall improvement.
Reviewed 1 of 8 files at r1, 9 of 21 files at r2, 9 of 9 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
All screenshots below are of the new design.
4 goals w/ history, wide (two different >= 900 px)
4 goals w/ history, narrow (two different <900 px)
3 goals w/o history (three different widths)
This change is