Codestin Search App

imnasnainaec · 2026-07-02T18:49:12Z

Also remove unnecessary ../ added to image paths in non-English user guide pages. They are now automatically resolved by mkdocs.

Devin: https://app.devin.ai/review/sillsdev/TheCombine/pull/4319

This change is

Summary by CodeRabbit

New Features
- Added Indonesian language support to the app and documentation site.
- Expanded the user guide with new Indonesian pages for account, project, data entry, data cleanup goals, and site administration.
Documentation
- Updated multiple translated guides so embedded screenshots reference the correct local assets.
- Reflowed/simplified formatting in several sections without changing instructions.
Bug Fixes
- Corrected localized “find & replace” error message placeholder formatting so interpolation displays consistently across languages.

coderabbitai · 2026-07-02T18:49:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9b34fac-4fe4-44ef-ab8e-8a952a993ff0

📥 Commits

Reviewing files that changed from the base of the PR and between 392e756 and 48652ca.

📒 Files selected for processing (21)

.github/workflows/localization_check.yml
docs/user_guide/docs/account.es.md
docs/user_guide/docs/account.id.md
docs/user_guide/docs/account.md
docs/user_guide/docs/account.zh.md
docs/user_guide/docs/admin.id.md
docs/user_guide/docs/admin.zh.md
docs/user_guide/docs/dataEntry.es.md
docs/user_guide/docs/dataEntry.id.md
docs/user_guide/docs/dataEntry.md
docs/user_guide/docs/dataEntry.zh.md
docs/user_guide/docs/goals.es.md
docs/user_guide/docs/goals.id.md
docs/user_guide/docs/goals.md
docs/user_guide/docs/goals.zh.md
docs/user_guide/docs/index.id.md
docs/user_guide/docs/project.es.md
docs/user_guide/docs/project.id.md
docs/user_guide/docs/project.md
docs/user_guide/docs/project.zh.md
public/locales/id/translation.json

✅ Files skipped from review due to trivial changes (15)

docs/user_guide/docs/account.md
docs/user_guide/docs/dataEntry.md
docs/user_guide/docs/admin.id.md
docs/user_guide/docs/account.id.md
docs/user_guide/docs/account.es.md
docs/user_guide/docs/goals.md
docs/user_guide/docs/dataEntry.zh.md
docs/user_guide/docs/index.id.md
docs/user_guide/docs/account.zh.md
public/locales/id/translation.json
docs/user_guide/docs/goals.es.md
docs/user_guide/docs/admin.zh.md
docs/user_guide/docs/goals.zh.md
docs/user_guide/docs/dataEntry.es.md
docs/user_guide/docs/project.zh.md

🚧 Files skipped from review as they are similar to previous changes (1)

docs/user_guide/docs/project.es.md

📝 Walkthrough

Walkthrough

Adds Indonesian UI localization support, new Indonesian user guide pages, and MkDocs language wiring. Updates existing user guide image paths and formatting in Spanish, Chinese, English, and other locale files, and normalizes a translation placeholder string across several languages.

Changes

Indonesian UI localization enablement

Layer / File(s)	Summary
UI language catalog `src/types/writingSystem.ts`, `public/locales/id/translation.json`, `README.md`	Adds Indonesian to the UI language list, adds the Indonesian translation catalog, and updates the README localization badge.
Localization checks `.github/workflows/localization_check.yml`	Expands the user-guide localization check to compare MkDocs i18n, search, alternate, and badge language sets.
Interpolation placeholder spacing `public/locales/ar/translation.json`, `public/locales/en/translation.json`, `public/locales/es/translation.json`, `public/locales/pt/translation.json`, `public/locales/zh/translation.json`	Normalizes the `{{ val2 }}` placeholder spacing in the character inventory find-and-replace error string across five locales.

Indonesian user guide pages

Layer / File(s)	Summary
MkDocs language wiring `docs/user_guide/mkdocs.yml`	Adds Indonesian navigation translations, search support, and an `/id/` alternate entry.
Index and account pages `docs/user_guide/docs/index.id.md`, `docs/user_guide/docs/account.id.md`	Adds the Indonesian user guide index and account page covering registration, login, password reset, and settings.
Admin page `docs/user_guide/docs/admin.id.md`	Adds the Indonesian admin page covering project management, user handling, and banners.
Data entry page `docs/user_guide/docs/dataEntry.id.md`	Adds the Indonesian data entry page covering entry creation, recording, and duplicate vernacular handling.
Goals page `docs/user_guide/docs/goals.id.md`	Adds the Indonesian data cleanup page covering review, merge, deferred duplicates, and spell checking.
Project page `docs/user_guide/docs/project.id.md`	Adds the Indonesian project page covering setup, users, speakers, import/export, schedules, semantic domains, and statistics.

Existing user guide asset and formatting updates

Layer / File(s)	Summary
Account and admin docs `docs/user_guide/docs/account.es.md`, `docs/user_guide/docs/account.zh.md`, `docs/user_guide/docs/admin.es.md`, `docs/user_guide/docs/admin.zh.md`	Updates screenshot paths from `../images/...` to `images/...` and reflows nearby account/admin Markdown.
Data entry docs `docs/user_guide/docs/dataEntry.es.md`, `docs/user_guide/docs/dataEntry.md`, `docs/user_guide/docs/dataEntry.zh.md`	Reflows data entry Markdown and updates duplicate-vernacular screenshots to `images/...`, including centered image formatting.
Goals docs `docs/user_guide/docs/goals.es.md`, `docs/user_guide/docs/goals.md`, `docs/user_guide/docs/goals.zh.md`	Reflows goals Markdown and updates screenshot paths across review, merge, and spell-check sections.
Project docs `docs/user_guide/docs/project.es.md`, `docs/user_guide/docs/project.md`, `docs/user_guide/docs/project.zh.md`	Reflows project Markdown and updates screenshot paths across project settings, users, import/export, schedules, semantic domains, and statistics.

Estimated code review effort: 3 (Moderate) | ~30 minutes

Possibly related PRs

sillsdev/TheCombine#4299: Overlaps with the translation catalog and other locale-string updates in this change set.

Suggested reviewers: jasonleenaylor

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding Indonesian UI support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch id2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-07-02T18:52:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.88%. Comparing base (e2b613d) to head (48652ca).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4319      +/-   ##
==========================================
- Coverage   75.96%   66.88%   -9.08%     
==========================================
  Files         305      248      -57     
  Lines       11384     6303    -5081     
  Branches     1411      794     -617     
==========================================
- Hits         8648     4216    -4432     
+ Misses       2332     1826     -506     
+ Partials      404      261     -143

Flag	Coverage Δ
backend	`?`
frontend	`66.88% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@public/locales/id/translation.json`:
- Line 335: Fix the typo in the `deleteConfirm` translation string by correcting
the missing space in the Indonesian copy; update the value in the locale entry
so the prompt reads naturally. Locate the string via `deleteConfirm` in the
translation JSON and adjust only that text.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 061452eb-1c51-4be1-b16e-009426d51bb7

📥 Commits

Reviewing files that changed from the base of the PR and between e2b613d and 392e756.

📒 Files selected for processing (25)

README.md
docs/user_guide/docs/account.es.md
docs/user_guide/docs/account.id.md
docs/user_guide/docs/account.zh.md
docs/user_guide/docs/admin.es.md
docs/user_guide/docs/admin.id.md
docs/user_guide/docs/admin.zh.md
docs/user_guide/docs/dataEntry.es.md
docs/user_guide/docs/dataEntry.id.md
docs/user_guide/docs/dataEntry.zh.md
docs/user_guide/docs/goals.es.md
docs/user_guide/docs/goals.id.md
docs/user_guide/docs/goals.zh.md
docs/user_guide/docs/index.id.md
docs/user_guide/docs/project.es.md
docs/user_guide/docs/project.id.md
docs/user_guide/docs/project.zh.md
docs/user_guide/mkdocs.yml
public/locales/ar/translation.json
public/locales/en/translation.json
public/locales/es/translation.json
public/locales/id/translation.json
public/locales/pt/translation.json
public/locales/zh/translation.json
src/types/writingSystem.ts

jasonleenaylor · 2026-07-08T20:58:34Z

docs/user_guide/docs/admin.es.md line 5 at r2 (raw file):

Los administradores del sitio disponen de una opción más en el menú de usuario: "Configuración del sitio".

![Menú de usuario - Administrador](../images/userMenuAdmin.es.png){.center}

So all the image links were broken?

jasonleenaylor

@jasonleenaylor reviewed 30 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

imnasnainaec · 2026-07-08T21:05:37Z

docs/user_guide/docs/admin.es.md line 5 at r2 (raw file):
Los administradores del sitio disponen de una opción más en el menú de usuario: "Configuración del sitio".

![Menú de usuario - Administrador](../images/userMenuAdmin.es.png){.center}
So all the image links were broken?

No, they worked because the mkdocs builder compensated for it, but it was a noisy build with all the warnings.

imnasnainaec self-assigned this Jul 2, 2026

github-actions Bot added documentation Improvements or additions to documentation frontend font/language labels Jul 2, 2026

Add Indonesian UI

4a5267b

imnasnainaec force-pushed the id2 branch from 35302c1 to 4a5267b Compare July 2, 2026 18:53

imnasnainaec added 2 commits July 2, 2026 16:30

Add Indonesian User Guide

672d67f

Fix outside links

392e756

imnasnainaec marked this pull request as ready for review July 2, 2026 20:47

coderabbitai Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread public/locales/id/translation.json Outdated

Add missing space

e013a6e

imnasnainaec marked this pull request as draft July 2, 2026 21:30

imnasnainaec added 6 commits July 3, 2026 13:42

Update User Guide translations

b1b62a2

Reflow user_guide docs

e6bc8f9

Add missing periods

11f8f1a

Revert unhelpful reflow

572178a

Translate domain name

7b0f782

Expand mkdocs check

48652ca

github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Jul 8, 2026

imnasnainaec marked this pull request as ready for review July 8, 2026 20:27

imnasnainaec added the 🟨Medium Medium-priority PR label Jul 8, 2026

jasonleenaylor approved these changes Jul 8, 2026

View reviewed changes

imnasnainaec merged commit 713f8de into master Jul 8, 2026
17 checks passed

imnasnainaec deleted the id2 branch July 8, 2026 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add Indonesian UI#4319

Add Indonesian UI#4319
imnasnainaec merged 10 commits into
masterfrom
id2

imnasnainaec commented Jul 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

codecov Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

jasonleenaylor commented Jul 8, 2026

Uh oh!

jasonleenaylor left a comment

Uh oh!

imnasnainaec commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

imnasnainaec commented Jul 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

codecov Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jasonleenaylor commented Jul 8, 2026

Uh oh!

jasonleenaylor left a comment

Choose a reason for hiding this comment

Uh oh!

imnasnainaec commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

imnasnainaec commented Jul 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

codecov Bot commented Jul 2, 2026 •

edited

Loading