Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC Move upgrade docs into changelog for 5.0.0 #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emteknetnz merged 1 commit into from
Sep 14, 2022
Merged

DOC Move upgrade docs into changelog for 5.0.0 #84

emteknetnz merged 1 commit into from
Sep 14, 2022

Conversation

@GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Sep 13, 2022

  • Moves everything in the "Upgrading your project" doc into the 5.0.0 changelog
  • Removes the PHPUnit and GraphQL upgrade docs in favour if linking to those docs from CMS 4
  • Moves dependency docs up to just below API changes as this is a more natural flow if you're looking at the changelog from an "I want to upgrade my project" pov.

Parent issue

@GuySartorelli GuySartorelli mentioned this pull request Sep 13, 2022
Closed
3 tasks
GuySartorelli
GuySartorelli commented Sep 13, 2022
View reviewed changes
en/04_Changelogs/5.0.0.md
Comment on lines +108 to +109
- silverstripe/graphql v3 is no longer supported. It is recommended that you ensure you are using graphl v4 in your Silverstripe CMS 4 project before upgrading to Silverstripe CMS 5. There is [documentation for the upgrade process here](https://docs.silverstripe.org/en/4/upgrading/upgrading_to_graphql_4/).
- PHPUnit 5.7 is no longer supported. It is recommended that you ensure your tests are running with PHPUnit 9 in your Silverstripe CMS 4 project before upgrading to Silverstripe CMS 5. There is [documentation for the upgrade process here](https://docs.silverstripe.org/en/4/upgrading/phpunit9/).
Copy link
Member Author

@GuySartorelli GuySartorelli Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these URLs are absolute because they point at docs from CMS 4

@emteknetnz emteknetnz merged commit db79fc5 into silverstripe:5 Sep 14, 2022
@emteknetnz emteknetnz deleted the pulls/5/changelog-is-upgrade-doc branch September 14, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuySartorelli @emteknetnz