Fix scope error in atomic thread test #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the threads should be destroyed first, before the atomic bool they use is destroyed. found by address sanitizer when using clang (had to temporarily enable the test to run even if thread sanitizer was disabled)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes two minor issues.
The first one is a scope issue in the atomic thread test. I discovered this by accident when fiddling around with the threaded test when running without thread sanitizer, but with address sanitizer.
The other is a temporary hack I committed by mistake. I believe it is harmless because it is only included in c++20 anyway, but it shall be removed regardless.