Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix default options #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2015
Merged

Fix default options #20

merged 1 commit into from
Oct 24, 2015

Conversation

jednano
Copy link
Collaborator

@jednano jednano commented Oct 24, 2015

Fixes #19

@jednano jednano added the bug label Oct 24, 2015
@jednano
Copy link
Collaborator Author

jednano commented Oct 24, 2015

@simonsmith can I get your review on these changes? I introduced tcomb to enforce valid plugin options as well as object-assign to override defaults, if new options are provided.

@jednano jednano force-pushed the fix-default-options branch from 114f5b4 to 4a28280 Compare October 24, 2015 05:47
@simonsmith
Copy link
Owner

lgtm, nice one

@simonsmith simonsmith changed the title [ISSUE-19] Fix default options Fix default options Oct 24, 2015
jednano pushed a commit that referenced this pull request Oct 24, 2015
@jedmao
Merge pull request #20 from jedmao/fix-default-options
fe60469 
Fix default options
@jednano jednano merged commit fe60469 into simonsmith:master Oct 24, 2015
@jednano jednano deleted the fix-default-options branch October 24, 2015 15:38
@onigoetz onigoetz mentioned this pull request May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jednano @simonsmith