Rename variables to avoid shadowing builtins #1137
Conversation
Fix some `flake8` `A00*` warnings that warn the usage of variables and arguments names that shadow some builtins variables, functions and modules.
|
There are some make flake | grep -E "A[0-9]+"@jcapriot what's your take on those? |
Codecov Report
@@ Coverage Diff @@
## main #1137 +/- ##
===========================================
- Coverage 80.23% 41.22% -39.02%
===========================================
Files 158 158
Lines 23010 23010
===========================================
- Hits 18463 9485 -8978
- Misses 4547 13525 +8978
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
renaming |
|
You're right, that's why I didn't want to touch them. I think we could add a deprecation warning for the |
|
We can probably tackle it when we finish up all the pep8 renaming |
Remove the A00* flake8 errors from the list of ignored warnings in the Makefile used by the `flake-permissive` target.
Flake8 complains after defining functions or methods named `eval` because they overwrite the builtin `eval` function. Renaming these functions and methods might break backward compatibility and it should be done with proper deprecation warnings. This is outside of the scope of this PullRequest.
|
@jcapriot I think this is ready to be merged. |
Fix some
flake8A00*warnings that warn the usage of variables andarguments names that shadow some builtins variables, functions and
modules.