Avoid using getattr with fixed constant strings #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `flake8` `B008` warnings. Refactor the way fixed attributes are obtained: instead of using `getattr` with fixed strings, use the standard `object.attribute` syntax that is more efficient and readable. Use `hasattr` for checking if the wanted attribute exists instead of using `getattr` and returning None if not: improves readability.
Codecov Report
@@ Coverage Diff @@
## main #1139 +/- ##
===========================================
+ Coverage 55.14% 80.23% +25.08%
===========================================
Files 158 158
Lines 23010 23012 +2
===========================================
+ Hits 12690 18464 +5774
+ Misses 10320 4548 -5772
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
looks good, I know the getattr is used fairly often for caching items on class instances. |
Member
Author
|
Indeed. It's a great tool to catch attributes programatically. But if the attribute's name is already known, having to allocate a string and calling if hasattr(obj, attr):
# Do something with obj.attribute
... |
e894467 to
3e83ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
flake8B009warnings. Refactor the way fixed attributes areobtained: instead of using
getattrwith fixed strings, use thestandard
object.attributesyntax that is more efficient and readable.Use
hasattrfor checking if the wanted attribute exists instead ofusing
getattrand returning None if not: improves readability.