-
Notifications
You must be signed in to change notification settings - Fork 280
Add option for amplitude threshold on UpdateSens directive #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm thinking we use the following properties:
|
|
I would personally vote for shorter keywords (e.g. "method", "normalization"), just for convenience. |
|
I think we need to be a little specific in case we add any other functionality. 'method' at first glance isn't particularly descriptive. |
Codecov Report
@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 81.35% 81.38% +0.02%
==========================================
Files 157 157
Lines 24148 24183 +35
==========================================
+ Hits 19646 19681 +35
Misses 4502 4502
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| wr **= 0.5 | ||
|
|
||
| # Apply thresholding | ||
| if self.threshold_method == "global": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this option doesn't get tested at the moment.
# Conflicts: # SimPEG/directives/directives.py
No description provided.