Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@domfournier
Copy link
Contributor

No description provided.

@dccowan
Copy link
Member

dccowan commented Jan 20, 2023

I'm thinking we use the following properties:

  • threshold (float), whose action depends on ...
  • threshold_method (str). Which can be one of:
    • 'global' - adds constant value prior to normalization
    • 'percentile' - picks threshold based on the percentile
    • 'amplitude' - picks threshold base on fraction of maximum amplitude
  • normalization_method (None, str). Which can be one of:
    • 'maximum' - normalizes by the maximum so that largest cell weights are 1
    • 'minimum' - normalizes by the lower value, after thresholding, so that smallest cell weights are 1

@domfournier
Copy link
Contributor Author

I would personally vote for shorter keywords (e.g. "method", "normalization"), just for convenience.

@dccowan
Copy link
Member

dccowan commented Jan 21, 2023

I think we need to be a little specific in case we add any other functionality. 'method' at first glance isn't particularly descriptive.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #1163 (de74ada) into main (3b8f86b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
+ Coverage   81.35%   81.38%   +0.02%     
==========================================
  Files         157      157              
  Lines       24148    24183      +35     
==========================================
+ Hits        19646    19681      +35     
  Misses       4502     4502              
Impacted Files Coverage Δ
SimPEG/directives/directives.py 81.49% <100.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wr **= 0.5

# Apply thresholding
if self.threshold_method == "global":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this option doesn't get tested at the moment.

@jcapriot jcapriot merged commit 988fce9 into main Mar 1, 2023
@jcapriot jcapriot deleted the mira_update_sens_weight_threshold branch March 1, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants