Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix flake E711 error: wrong comparison with None #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcapriot merged 2 commits into from
Jun 21, 2023
Merged

Fix flake E711 error: wrong comparison with None #1242

jcapriot merged 2 commits into from
Jun 21, 2023

Conversation

@santisoler
Copy link
Member

@santisoler santisoler commented Jun 20, 2023 •
edited
Loading

Summary

Remove E711 from the list of ignored errors in .flake8. Compare variables against None with is or is not instead of == and !=.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Added relevant method tags (i.e. GRAV, EM, etc.)
  • Marked as ready for review (ff this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

Would be nice to merge this after #1238. The E711 error should be removed
from the .flake8 file.

TODO

@santisoler
Fix flake E711 error: wrong comparison with None
4f1c59c 
Remove `E711` from the list of ignored errors in `Makefile`. Compare
variables against `None` with `is` or `is not` instead of `==` and `!=`.
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #1242 (8029b42) into main (b8dcec5) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         164      164           
  Lines       24958    24958           
=======================================
  Hits        20544    20544           
  Misses       4414     4414
Impacted Files Coverage Δ
SimPEG/utils/io_utils/io_utils_electromagnetics.py 82.57% <0.00%> (ø)
...mPEG/electromagnetics/static/utils/static_utils.py 72.95% <100.00%> (ø)

@santisoler santisoler changed the title Fix flake E711 error: wrong comparison with None Fix flake E711 error: wrong comparison with None Jun 20, 2023
@jcapriot jcapriot merged commit 73e1555 into simpeg:main Jun 21, 2023
@santisoler santisoler deleted the flake-none branch June 21, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@santisoler @jcapriot