There are two unfixed warnings that I left because they are not trivial to solve.

The first one is on SimPEG/electromagnetics/time_domain/simulation.py, where getRHSDeriv is redefined:

The second one is on tests/em/tdem/test_TDEM_DerivAdjoint.py, with test_Jvec_adjoint_b_ey. In the first definition, it uses the "ElectricFieldy":

while in the redefinition is uses "CurrentDensity":

@lheagy maybe you could provide some insight here.

There are two unfixed warnings that I left because they are not trivial to solve.

The first one is on SimPEG/electromagnetics/time_domain/simulation.py, where getRHSDeriv is redefined:

simpeg/SimPEG/electromagnetics/time_domain/simulation.py

Lines 1050 to 1060 in b8dcec5

	def getRHSDeriv(self, tInd, src, v, adjoint=False):
	C = self.mesh.edge_curl
	s_m, s_e = src.eval(self, self.times[tInd])
	if adjoint is True:
	return self.MfRhoDeriv(s_e, C * v, adjoint)
	# assumes no source derivs
	return C.T * self.MfRhoDeriv(s_e, v, adjoint)
	def getRHSDeriv(self, tInd, src, v, adjoint=False):
	return Zero() # assumes no derivs on sources

The second one is on tests/em/tdem/test_TDEM_DerivAdjoint.py, with test_Jvec_adjoint_b_ey. In the first definition, it uses the "ElectricFieldy":

simpeg/tests/em/tdem/test_TDEM_DerivAdjoint.py

Lines 273 to 274 in b8dcec5

	def test_Jvec_adjoint_b_ey(self):
	self.JvecVsJtvecTest("ElectricFieldy")

while in the redefinition is uses "CurrentDensity":

simpeg/tests/em/tdem/test_TDEM_DerivAdjoint.py

Lines 288 to 289 in b8dcec5

	def test_Jvec_adjoint_b_ey(self):
	self.JvecVsJtvecTest("CurrentDensityy")

@lheagy maybe you could provide some insight here.

I actually think the first one might be the reason that the magnetic field source derivative tests are failing... #1233

as far as the second one, I believe it should be renamed to ..._jy instead of ..._ey

Thanks @jcapriot! I'm just keeping the record that the first case was fixed in 501aa0f

I've just pushed the change to fix the other one with your suggestion (which actually makes sense).

Codecov Report

Merging #1248 (41f98df) into main (9e08237) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files         164      164           
  Lines       24965    24961    -4     
=======================================
- Hits        20549    20546    -3     
+ Misses       4416     4415    -1