Set storage type of pf sensitivity matrix #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also avoids double storing the sensitivity matrix when concatenating it.
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
==========================================
+ Coverage 81.54% 82.40% +0.85%
==========================================
Files 164 164
Lines 25073 25095 +22
==========================================
+ Hits 20447 20679 +232
+ Misses 4626 4416 -210
|
santisoler
reviewed
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows users to control the type of the stored sensitivity matrix.
PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.What does this implement/fix?
In the non-dask version the sensitivity was being stored as a
np.float64implicitly. This changes it to be in line with the dask version (np.float32), but also now allows the user to change the default if they so desire.