My question would be do we need another way to call getting the J function? I.e. the compute_J function. We should probably just leave it as a single function using what we’ve already established.

My question would be do we need another way to call getting the J function? I.e. the compute_J function. We should probably just leave it as a single function using what we’ve already established.

So just lump this all into the getJ function?

@jcapriot , https://github.com/JKutt/simpeg/blob/c5d54c5b1c31eea9e9e3e9b281e40d9f8b030135/SimPEG/meta/simulation.py#L312C17-L313C53

these lines don't seem to execute and the model does not get passed down to the sub simulations. Is there a place I should be setting this self._repeat_sim?

@jcapriot , https://github.com/JKutt/simpeg/blob/c5d54c5b1c31eea9e9e3e9b281e40d9f8b030135/SimPEG/meta/simulation.py#L312C17-L313C53

these lines don't seem to execute and the model does not get passed down to the sub simulations. Is there a place I should be setting this self._repeat_sim?

No, you shouldn't mess with that property, it is only used when there is actually a RepeatedSimulation (i.e. a single simulation is used repeatedly for multiple models). If you look further up in that function you linked, when it sets self.model = m, it should go through the MetaSimulation's model setter, which then will echo the model to all sub simulations.

Codecov Report

Attention: Patch coverage is 97.10145% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.27%. Comparing base (7420f93) to head (3d2ad2a).

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   82.24%   82.27%   +0.03%     
==========================================
  Files         165      165              
  Lines       25162    25225      +63     
==========================================
+ Hits        20694    20755      +61     
- Misses       4468     4470       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simpeg/simpeg-developers

@jcapriot , @santisoler , examples are working and tests are passing! Though have a look at the pde_simulation.py modifications. specifically the function __inner_mat_mul_op. For the adjoint, I had to add a case for when the second dimension is larger than 2. When building the full J matrix I am passing v as an identity matrix. Perhaps there is a more elegent way to do this? Let me know what you think.

This is now good to go on my end, had to fix a few implementation errors