Ditch deprecated functions in utils.model_builder #1311
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
- Coverage 82.35% 82.34% -0.01%
==========================================
Files 165 165
Lines 25239 25228 -11
==========================================
- Hits 20785 20774 -11
Misses 4454 4454 ☔ View full report in Codecov by Sentry. |
Remove the deprecated `model_builder.addBlock` function and update some tests that were using it.
santisoler
left a comment
There was a problem hiding this comment.
Thanks @domfournier for this! I've started working on ditching deprecated function in https://github.com/simpeg/simpeg/tree/ditch-deprecated (I'll open a PR shortly). I haven't worked on these functions yet, so these changes are greatly appreciated.
I just pushed a few commits to this branch to remove the deprecated functions, and also update some bits that were still using the deprecated functions. Hopefully CI won't fail. In case it does fail, feel free to push further changes.
|
Great @santisoler , getting cleaner. I have noticed some random failures of the dask.dc test though. It also happened to other PRs, so not related to this PR. Created issue #1315 to investigate. I would suggest we just re-fire the test here until it passes. |
|
Thanks for opening that issue. If the test involves some random numbers, the failing might be related to #1289 |
|
Now tests passed. I'm merging this! |
* ta/weighting_strategy: fix new depreciation Ditch deprecated functions in utils.model_builder (simpeg#1311) more warnings move warning try fix `| None` test error stacklevel fix tests address comments One more randn switch tutorials rand to randn
|
Can you help me to find what is the error? |
Addresses name change for functions in
utils.model_builder.Update tutorials, examples and tests that were using the deprecated functions.
Related to issue #1265