ISSUE-1298: Use normal distributed noise in example. #1312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 165 165
Lines 25239 25239
=======================================
Hits 20785 20785
Misses 4454 4454 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good! Feel free to merge 🚀
Just one comment for future PRs on Numpy's random number generation: I think we should move from using the np.random.... functions for the new random number generator class: https://numpy.org/doc/stable/reference/random/generator.html
This class introduces a more transparent way on handling random seeds and also a more verbose interface: numbers with normal distributions can be generated with rng.normal(), while using a uniform distribution can be done with rng.uniform().
I've started applying these changes in #1286
Again, we should merge this PR as it is!
|
Ok, great. |
Change reference to random.rand to random.randn for a centred normal distribution.
Address issue #1298