Move __init__ in BaseSimulation to the top of the class
#1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the `__init__`` method in `BaseSimulation` to the top of the class. This just improves readability and shouldn't change the behaviour of the class.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1323 +/- ##
=======================================
Coverage 82.30% 82.30%
=======================================
Files 165 165
Lines 25244 25244
=======================================
Hits 20778 20778
Misses 4466 4466 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Style checks are failing on CI (not locally) because different versions of flake and its plugins are being installed in Azure. I'm fixing that in #330. |
thibaut-kobold
added a commit
to KoBoldMetals/simpeg
that referenced
this pull request
Jan 22, 2024
* main: Fix typo in error messages (simpeg#1324) Update test_regularization.py to test vector derivatives. Update AmplitudeSmoothnessFirstOrder in vector.py so that the call matches the derivative. Move `__init__` in `BaseSimulation` to the top of the class (simpeg#1323) Bump versions of flake8 and black and pin flake plugins (simpeg#1330) Update test_regularization.py to test vector derivatives. Update AmplitudeSmoothnessFirstOrder in vector.py so that the call matches the derivative. Update test_regularization.py to test vector derivatives. Update AmplitudeSmoothnessFirstOrder in vector.py so that the call matches the derivative. Add `weights_keys` method to `BaseRegularization` (simpeg#1320) Fix description of source_field in gravity survey (simpeg#1322) Documentation improvements for classes in Objective Function Pieces (simpeg#1292) # Conflicts: # tests/base/regularizations/test_regularization.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the
__init__`` method inBaseSimulation` to the top of the class. This just improves readability and shouldn't change the behaviour of the class.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
What does this implement/fix?
Additional information