Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use choclo in gravity tutorials #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
santisoler merged 6 commits into from
Mar 14, 2024
Merged

Use choclo in gravity tutorials #1378

santisoler merged 6 commits into from
Mar 14, 2024

Conversation

@santisoler
Copy link
Member

@santisoler santisoler commented Mar 12, 2024 •
edited
Loading

Summary

Use engine="choclo" in tutorials that make use of gravity simulations. Add an admonition instructing on how to use the engine argument.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

@codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (c9acbd4) to head (491a3d5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   82.24%   82.25%           
=======================================
  Files         165      165           
  Lines       25173    25173           
=======================================
+ Hits        20704    20705    +1     
+ Misses       4469     4468    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler santisoler mentioned this pull request Mar 12, 2024
Closed
@santisoler santisoler changed the title Use choclo in forward gravity tutorial Use choclo in gravity tutorials Mar 13, 2024
@santisoler santisoler marked this pull request as ready for review March 13, 2024 16:54
lheagy
lheagy approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@lheagy lheagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! So nice to expose the connection with choclo 🌽

@santisoler santisoler added this to the 0.21.0 milestone Mar 14, 2024
@santisoler santisoler merged commit 4a3bab1 into main Mar 14, 2024
@santisoler santisoler deleted the gravity-choclo-docs branch March 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lheagy lheagy lheagy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@santisoler @lheagy