Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure the queue's are joined when the meta simulation is joined. #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcapriot merged 2 commits into from
May 15, 2024
Merged

Ensure the queue's are joined when the meta simulation is joined. #1464

jcapriot merged 2 commits into from
May 15, 2024

Conversation

@jcapriot
Copy link
Member

@jcapriot jcapriot commented May 15, 2024 •
edited
Loading

Summary

Join's the multiprocessing queues in the MultiprocessingMetaSimulation when the simulation is joined.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

What does this implement/fix?

Likely caused the broken pipe errors in the testing environment.

@codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (e13a25f) to head (f8f4e9b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   82.55%   82.56%           
=======================================
  Files         168      168           
  Lines       25718    25728   +10     
=======================================
+ Hits        21232    21242   +10     
  Misses       4486     4486

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler santisoler mentioned this pull request May 15, 2024
Merged
8 tasks
@jcapriot
Copy link
Member Author

jcapriot commented May 15, 2024

Currently on main there are broken pipe errors when the multiprocessing tests finish up: main error
With the change the join process is a little cleaner on exit no errors on this branch

@jcapriot jcapriot merged commit 80e3b18 into simpeg:main May 15, 2024
@jcapriot jcapriot deleted the queue_join branch May 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcapriot