Minor improvements to UpdateIRLS class
#1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `reg` objects at this point are only `Sparse` due to previous check.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
+ Coverage 86.06% 86.08% +0.01%
==========================================
Files 397 397
Lines 51018 51052 +34
Branches 5684 5684
==========================================
+ Hits 43911 43949 +38
+ Misses 5671 5670 -1
+ Partials 1436 1433 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove unneeded if statement, since the
regobjects at that point are onlySparsedue to previous check. Update comments to reflect better what the code does. Add tests to check ifirls_thresholdis correctly updated.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
Minor improvements to changes made in #1349
What does this implement/fix?
Additional information