Replace seed for random_seed in directives
#1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the `seed` argument and property in directives and replace it by `random_seed`.
Replace the `seed` argument for a new `random_seed` argument in eigenvalue_by_power_iteration.
Update calls to `eigenvalue_by_power_iteration` so they use `random_seed` instead of `seed`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
+ Coverage 86.08% 86.11% +0.02%
==========================================
Files 397 397
Lines 51052 51139 +87
Branches 5684 5698 +14
==========================================
+ Hits 43949 44036 +87
Misses 5670 5670
Partials 1433 1433 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
seedforrandom_seedin directive classes. Replace theseedargument for a newrandom_seedargument ineigenvalue_by_power_iteration. Update usage ofseedargument in tests and in codebase. Add tests to check the deprecations.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.Reference issue
Part of #1461
What does this implement/fix?
Additional information
TODO
seedin examples and tutorials