Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove empymod dependency #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcapriot merged 8 commits into from
Nov 3, 2024
Merged

Remove empymod dependency #1571

jcapriot merged 8 commits into from
Nov 3, 2024

Conversation

@jcapriot
Copy link
Member

@jcapriot jcapriot commented Nov 2, 2024 •
edited
Loading

Summary

empymod is a pretty heavy dependency for the functionality we are using from it. This removes the dependency and instead uses libdlf to get the filters, and a streamlined get_splined_dlf_points for our internal use.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Additional information

I say empymod is a heavy dependency because it in turn relies on numba.

@codecov
Copy link

codecov bot commented Nov 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (e210404) to head (95b39ca).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   86.41%   86.44%   +0.02%     
==========================================
  Files         406      407       +1     
  Lines       52413    52475      +62     
  Branches     4991     4997       +6     
==========================================
+ Hits        45294    45361      +67     
+ Misses       5691     5687       -4     
+ Partials     1428     1427       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot jcapriot merged commit a86146f into simpeg:main Nov 3, 2024
@jcapriot jcapriot deleted the libdlf branch November 3, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcapriot