Codecov Report

❌ Patch coverage is 96.83544% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.54%. Comparing base (5f060ec) to head (ccc08b7).

@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
+ Coverage   81.52%   81.54%   +0.02%     
==========================================
  Files         420      420              
  Lines       55174    55231      +57     
  Branches     5254     5271      +17     
==========================================
+ Hits        44978    45038      +60     
+ Misses       8790     8783       -7     
- Partials     1406     1410       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I left a few minor comments, @dccowan. Please check them out and let me know what do you think.

I see that coverage is missing L782-L783 in receivers.py. Could we add an extra test case to cover that if statement?

Thanks for putting this together!

Sure. Before finishing this PR however, I would like have PR #1683 merged. It will make things related to the 2D simulation easier to test.

I left a few minor comments, @dccowan. Please check them out and let me know what do you think.

I see that coverage is missing L782-L783 in receivers.py. Could we add an extra test case to cover that if statement?

Thanks for putting this together!

I'm not sure these lines are necessary for 3D. I think it may just be for the 3D problem geometry. I noticed the 2D problem geometry for impedance type data doesn't have this functionality. So I've decided to remove these lines.