Avoids calculating unused values for boundary conditions on DC 2D simulations #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
=======================================
Coverage ? 86.05%
=======================================
Files ? 430
Lines ? 55745
Branches ? 5177
=======================================
Hits ? 47974
Misses ? 6372
Partials ? 1399 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Avoid performing calculations for DC boundary conditions on the top of the mesh, where the simulation always explicitly uses a zero Neumann condition.
PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developerswhen ready for review.What does this implement/fix?
By avoiding evaluating these locations at the top of the mesh, we avoid the 'DivideByZero' warning.