Also mirror the calledOnceWith assertion#2660
Merged
Merged
Conversation
fatso83
approved these changes
Jun 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 39 39
Lines 1891 1892 +1
=======================================
+ Hits 1812 1813 +1
Misses 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi, thanks for doing this! Could you also just run Prettier on the changes? seems to fail on that step. |
9e9d050 to
8d020a6
Compare
Contributor
Author
Done. Also added the method to the documentation. |
Contributor
Author
|
Should be ready now. |
Contributor
Author
|
@mroderick @fatso83 thanks for merging the fix. Could you release a 21.1.0 version, so we start using this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
For Chrome DevTools front-end testing we generally prefer the
sinon.assert.foo(spy, ...)form overassert.isTrue(spy.foo(...)), andcalledOnceWithis missing from thesinon.assertobject currently.Solution - optional
It's pretty straight-forward to also expose the
calledOnceWithon thesinon.assertobject.How to verify - mandatory
npm installnpm test(specifically thetest/assert-test.jsfile checks that the method is properly exposed)Checklist for author
npm run lintpasses