fix(sidebar): refresh on session-created; stabilize streaming and navigation (supersedes #159) #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Live updates: incremental WS processing with immutable updates; dedupe final text; lock streaming ownership to the intended session; ignore increments when viewing another session; stable keys. (Claude unaffected) - Post-completion sync: after cursor-result, silently reload authoritative session history and replace only if richer/different; guard by current viewed session and clear timers on session change. File: src/components/ChatInterface.jsx
…n init - Only navigate to /session/:id when current URL is '/' - Avoid clearing selectedSession for Cursor when projects_updated lacks cursorSessions - Sidebar refresh now also fetches cursorSessions to update sessions list properly This addresses rapid page switches (flashing) and stale sidebar sessions.
- On receiving session-created with a sessionId, if current URL is '/', navigate to /session/:id and mark as system session change to preserve current chat content. This matches manual clicking behavior and stops the flicker loop.
- Navigate once to /session/:id when at '/' using a ref guard - Avoid await/prefetch to prevent async issues and request bursts
- Remove automatic /api/cursor/config fetch from ChatInterface - Mount only active tab (Files/Shell/Git not mounted on Chat) - Avoid auto refreshProjects calls after cursor session completes
…n-update - Trigger the exact same logic as clicking the Sidebar refresh button (`handleSidebarRefresh`) when a new real session id arrives via WebSocket. - Schedule a single delayed refresh (800ms) to avoid racing backend persistence; cancel the pending refresh if a `projects_updated` containing the session arrives first. - Loosen additive-update guard so Sidebar can update during active sessions (Cursor always additive; Claude checks existence by id only). - Prevent WS message reprocessing loop in ChatInterface by advancing processed index before early return on auto navigation.
|
@xavierliang Can you check if the PR is still needed with the v1.8.1 changes in the sessions ? |
|
Yes, it's still needed |
|
@xavierliang thanks. are you able to resolve the conflicts and test it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR supersedes and replaces #159. It includes all improvements from #159 (stabilizing streaming message rendering and post-completion sync), and adds a robust Sidebar refresh mechanism for newly created sessions.
Brought over from #159
activeCursorStreamSessionIdRefandpendingCursorViewingSessionIdRef.session-createdarrives, auto-navigate only from/and avoid double-handling by advancing the processed index before returning.cursor-result, silently reload and replace history if the fetched log is richer or differs.New in this PR
session-created: schedule a single delayed refresh (same behavior as clicking the Sidebar refresh button), and cancel it if an incomingprojects_updatedalready includes the new session.Related issues
Test plan