D:OD:D:BaseObject should pass the whole args to fallback. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziguzagu
added a commit
that referenced
this pull request
Mar 13, 2015
D:OD:D:BaseObject should pass the whole args to fallback.
Contributor
|
@aklaswad thanks! |
ziguzagu
added a commit
that referenced
this pull request
Mar 28, 2015
Changelog diff is: diff --git a/Changes b/Changes index 54df798..17ae8ba 100644 --- a/Changes +++ b/Changes @@ -1,3 +1,12 @@ +{{$NEXT}} + +0.11 2015-03-28T10:04:24Z + + - Fix test (ambs) #16 + - Migrate to Minilla (ziguzagu) #17 + - Pass the whole args to fallback driver. (Akira Sawada) #18 + - Remove a joined table from the "FROM" phrase for fix error on MySQL. (usualoma) #7 + 0.10 2015.01.14 - Document spelling corrections (dsteinbrunner) #8 #9 #10 #11 #12 #13 #14 @@ -13,7 +22,6 @@ - Adds a new restricted IO operation mode controlled by the $Data::ObjectDriver::RESTRICT_IO flag (Brad Whitaker) -Revision history for Data::ObjectDriver 0.07 2010.03.22 - When an object is changed, delete the cache instead of updating it. It is a bit more expensive, but should safer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using D::OD w/ any cache layer and try to update some column with not only primary key but also specifying additional terms, Data::ObjectDriver::Driver::BaseCache->update just ignores the
$termsbackground
The end of my tackle to TheSchwartz's weird behavior, I found this.
By looking https://github.com/saymedia/TheSchwartz/blob/master/lib/TheSchwartz.pm#L335 TS is trying to run UPDATE statement with using
grabbed_untilcolumn for both SET and WHERE clause - to avoid contention. But D::OD Cache layer doesn't pass$termsto fallbacks, so this couldn't work.