Change the closing timing of $sth when inserting/creating records. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziguzagu
added a commit
that referenced
this pull request
May 14, 2015
Change the closing timing of $sth when inserting/creating records.
Contributor
|
thanks |
ziguzagu
added a commit
that referenced
this pull request
May 20, 2015
Fix the order of processes changed in pullreq #19.
ziguzagu
added a commit
that referenced
this pull request
May 20, 2015
Changelog diff is: diff --git a/Changes b/Changes index 0cb62d5..53c63c4 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,9 @@ {{$NEXT}} +0.13 2015-05-20T02:26:46Z + + - Fix 0.12 changes with braking inserting new records (masiuchi) #20 + 0.12 2015-05-18T05:33:33Z - Fix broken $sth at inserting new records (masiuchi) #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$sth cannot be used in $dbd->fetch_id.
https://github.com/sixapart/data-objectdriver/blob/0.11/lib/Data/ObjectDriver/Driver/DBI.pm#L406
$sth is closed before calling $dbd->fetch_id.
https://github.com/sixapart/data-objectdriver/blob/0.11/lib/Data/ObjectDriver/Driver/DBI.pm#L398
I want to change the closing timing of $sth.