Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC simplify ToFloat import example - #2212

Merged
rcap107 merged 2 commits into
skrub-data:mainfrom
Khadija-de:docs-fix-tofloat-import
Jul 16, 2026
Merged

DOC simplify ToFloat import example#2212
rcap107 merged 2 commits into
skrub-data:mainfrom
Khadija-de:docs-fix-tofloat-import

Conversation

@Khadija-de

Copy link
Copy Markdown
Contributor

Fixes #2130.

This updates the ToFloat docstring example to import ToFloat from the public skrub API instead of the private skrub._to_float module.

@Khadija-de

Khadija-de commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Hi, thank you for reviewing.

I checked the failing CI jobs. Both Run pre-commit checks and Check if .pyi file differs from generated one seem to fail while resolving dependencies for the ci-nightly-deps environment on macOS, before running the actual checks.

The error mentions that scikit-learn>=1.4.2 cannot be resolved from the configured indexes.

Since this PR only updates one docstring import example from a private module to the public API, I think the CI failure may be unrelated to this change. Please let me know if there is anything I should update from my side.

@jeromedockes

Copy link
Copy Markdown
Member

Thank you for this contribution @Khadija-de ! indeed there seems to be a temporary failure with the package index from which the CI installs some packages for some of the jobs, it is unrelated to your change and affects other Pull Requests as well. We will re-run the CI job once it is resolved

@rcap107

rcap107 commented Jul 16, 2026

Copy link
Copy Markdown
Member

All good! The CI is running.

@rcap107 rcap107 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @Khadija-de

@rcap107
rcap107 merged commit ea84df5 into skrub-data:main Jul 16, 2026
29 checks passed
@Khadija-de
Khadija-de deleted the docs-fix-tofloat-import branch July 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: simplify the import of ToFloat in its docstring

3 participants