-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ENH ] skchange homogenization: variable identification + minor fixes #7509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Some comments:
- the PR does not contain all changes mentioned in the preamble. Still WiP?
- There is a similar tag to
capability:variable_identification
which already exists,capability:feature_importance
, already - formally, the root cause or variable identification function is a 0/1 feature importance. We could therefore consider using that?
Yes, still work in progress.
The nice thing about having a separate tag is that you can specify exactly what it means for detectors: That the output of |
You can still do this if you use the same tag - by tests or docstring, no? But I do agree that it actually means something different for detectors, since we have feature importances per time index. A separate tag makes sense (I am now increasingly convinced of that) - although I wonder whether it can be shortened. |
|
…-homogenization
not much shorter...
|
Sorry, I forgot about following up this. I think all our options here are pretty long, so therefore I'd go with the most self-explanatory name. I still think this is What about |
I think the noun variant, i.e., |
Alright. Then I think this PR is ready. |
…-homogenization
…ktime into skchange-homogenization
Reference Issues/PRs
Fixes #7323. See also NorskRegnesentral/skchange#44 and NorskRegnesentral/skchange#49
What does this implement/fix? Explain your changes.
What should a reviewer concentrate their feedback on?
Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktime
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
maintainers
tag - do this if you want to become the owner or maintainer of an estimator you added.See here for further details on the algorithm maintainer role.