Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Reckadon
Copy link
Contributor

@Reckadon Reckadon commented Feb 18, 2025

replaced 3.12 with 3.13 in pyrpject.toml for tensorflow's max python version requirement

Reference Issues/PRs

Fixes #7858

What does this implement/fix? Explain your changes.

Changed 'tensorflow<2.17,>=2; python_version < "3.12"' to 'tensorflow<2.17,>=2; python_version < "3.13"' everywhere in pyproject.toml

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

Referenced Tensorflow's Release Notes

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

replaced 3.12 with 3.13 in pyrpject.toml for tensorflow's max python version requirement
@yarnabrina yarnabrina merged commit e8d6de0 into sktime:main Feb 22, 2025
199 checks passed
PranavBhatP pushed a commit to PranavBhatP/sktime that referenced this pull request Mar 5, 2025
sktime#7865)

replaced 3.12 with 3.13 in pyrpject.toml for tensorflow's max python
version requirement

<!--
Welcome to sktime, and thanks for contributing!
Please have a look at our contribution guide:
https://www.sktime.net/en/latest/get_involved/contributing.html
-->

#### Reference Issues/PRs
Fixes sktime#7858 
<!--
Please use keywords (e.g., Fixes) to create link to the issues or pull
requests
you resolved, so that they will automatically be closed when your pull
request
is merged. See
https://github.com/blog/1506-closing-issues-via-pull-requests.
If no issue exists, you can open one here:
https://github.com/sktime/sktime/issues
-->


#### What does this implement/fix? Explain your changes.
Changed `'tensorflow<2.17,>=2; python_version < "3.12"'` to
`'tensorflow<2.17,>=2; python_version < "3.13"'` everywhere in
`pyproject.toml`
<!--
A clear and concise description of what you have implemented.
-->

#### Does your contribution introduce a new dependency? If yes, which
one?
No
<!--
Only relevant if you changed pyproject.toml.
We try to minimize dependencies in the core dependency set. There
are also further specific instructions to follow for soft dependencies.
See here for handling dependencies in sktime:
https://www.sktime.net/en/latest/developer_guide/dependencies.html
-->

#### Any other comments?
Referenced [Tensorflow's Release
Notes](https://github.com/tensorflow/tensorflow/releases/tag/v2.16.1)
<!--
We value all user contributions, no matter how small or complex they
are. If you have any questions, feel free to post
in the dev-chat channel on the sktime discord
https://discord.com/invite/54ACzaFsn7. If we are slow to review (>3
working days), likewise feel free to ping us on discord. Thank you for
your understanding during the review process.
-->

#### PR checklist
<!--
Please go through the checklist below. Please feel free to remove points
if they are not applicable.
-->

##### For all contributions
- [ ] I've added myself to the [list of
contributors](https://github.com/sktime/sktime/blob/main/CONTRIBUTORS.md)
with any new badges I've earned :-)
How to: add yourself to the [all-contributors
file](https://github.com/sktime/sktime/blob/main/.all-contributorsrc) in
the `sktime` root directory (not the `CONTRIBUTORS.md`). Common badges:
`code` - fixing a bug, or adding code logic. `doc` - writing or
improving documentation or docstrings. `bug` - reporting or diagnosing a
bug (get this plus `code` if you also fixed the bug in the
PR).`maintenance` - CI, test framework, release.
See here for [full badge
reference](https://allcontributors.org/docs/en/emoji-key)
- [ ] Optionally, for added estimators: I've added myself and possibly
to the `maintainers` tag - do this if you want to become the owner or
maintainer of an estimator you added.
See here for further details on the [algorithm maintainer
role](https://www.sktime.net/en/latest/get_involved/governance.html#algorithm-maintainers).
- [x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG].
[BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving
code, [DOC] - writing or improving documentation or docstrings.


<!--
Thanks for contributing!
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tensorflow not being installed even after installing dl dependencies.
3 participants