[DOC] FCNClassifier - add Wang et al reference
#7884
Conversation
FCNClassifier - add Wang et al reference
There was a problem hiding this comment.
Thanks!
- code formatting is failing, see here https://www.sktime.net/en/stable/developer_guide/coding_standards.html or in the detail sof the failing CI element
- the reference in the text at the top should also be updated, currently it points to reference 1. Reference to 2 should be added, and perhaps 1 should be referred to differently or not at all?
- is there code on GitHub that could have been copied? If so, the GitHub user names should also be credited in the
"authors"tag.
Re that, I remember that code was actually copied, from @hfawaz - we added the credits some time ago. I also found these and this: I have not checked if the implementations are very similar, but I think @hfawaz is probably the entire copy tree, the other references may be independent. |
|
Thank you for your comment, @fkiraly.
According to my understanding of the style, 88 characters should be there, but I had more than that. Fixed comit for this
This is also implemented. Let me know any additional things you would like me to look on this. |
When I compared the code, it did not seemed to be copied. Let me know, if you would like me to further verify this. |
|
@fkiraly can you please run the checks. Thank You! |
Just for reference, you can locally check the estimator changed using |
Sure - thank you! The code formatting is still failing, likely a space or newline somewhere. |
#### Reference Issues/PRs Fixes sktime#7862 #### What does this implement/fix? Explain your changes. Adds Wang et al. as in the references for the FCN classifier docs
Reference Issues/PRs
Fixes #7862
What does this implement/fix? Explain your changes.
Adds Wang et al. as in the references for the FCN classifier docs
Any other comments?
As pointed out by @fkiraly for checking for the FCN Regressor, I was unable to see their contribution towards it, so I have not added it there.