Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

OnePunchMonk
Copy link
Contributor

@OnePunchMonk OnePunchMonk commented Jun 2, 2025

Reference Issues/PRs

Fixes #8227

What does this implement/fix? Explain your changes.

This PR enhances the percentage-based metrics classes by adding a relative_to parameter that allows users to normalize errors by the predicted values as well instead of just the actuals.

Does your contribution introduce a new dependency? If yes, which one?

No

What should a reviewer concentrate their feedback on?

Correctness and further changes required

Did you add any tests for the change?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@OnePunchMonk
Copy link
Contributor Author

@fkiraly kindly share the further changes to be made.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 1, 2025

This is abandoned, I completed the outstanding items for merge.

@fkiraly fkiraly added enhancement Adding new functionality module:metrics&benchmarking metrics and benchmarking modules labels Aug 1, 2025
@fkiraly fkiraly changed the title [ENH] Added relative_to support for percentage error classes [ENH] relative_to=y_pred support for percentage error forecasting metric classes Aug 1, 2025
@fkiraly fkiraly merged commit 3639afb into sktime:main Aug 2, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:metrics&benchmarking metrics and benchmarking modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] percentage metrics should allow "divided by forecast"
2 participants