Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

piyushbiraje
Copy link
Contributor

@piyushbiraje piyushbiraje commented Jun 2, 2025

Summary

Related to #4303

This PR adds complete docstrings for the following performance metrics in sktime/performance_metrics/forecasting/_classes.py:

  • MeanAbsoluteScaledError (MASE)
  • MedianAbsoluteSquaredError (MEDASE)

Changes

  • Added detailed math notation using .. math:: blocks
  • Ensured docstring formatting passes all linting checks (ruff, make check)

Checklist

  • Code linted (ruff, no E501/W293)
  • All tests passed locally via pytest sktime/performance_metrics
  • Docstring complete as per dev instructions
  • Ready for review

@fkiraly fkiraly added documentation Documentation & tutorials module:metrics&benchmarking metrics and benchmarking modules labels Jun 3, 2025
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only a minor point about newlines.

@fkiraly fkiraly changed the title [DOC] Added mathematical formulae for MASE and MedASE [DOC] mathematical formulae for MASE and MedASE Jun 4, 2025
@piyushbiraje
Copy link
Contributor Author

Thanks for reviewing and approving the PR! Let me know if there’s anything else needed from my side.

@fkiraly fkiraly merged commit e1c90c1 into sktime:main Jun 6, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials module:metrics&benchmarking metrics and benchmarking modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants