[ENH] Move Test Skip config for ResNetClassifier
#8564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
reviewed
Jul 16, 2025
| # `test_fit_idempotent` fails with `AssertionError`, see #3616 | ||
| "tests:skip_by_name": [ | ||
| "test_fit_idempotent", | ||
| "test_persistence_via_pickle", |
There was a problem hiding this comment.
where are you getting the last two from? This does not look equivalent.
fkiraly
requested changes
Jul 16, 2025
ResNetClassifier
fkiraly
approved these changes
Jul 16, 2025
|
I saw what others did for the same issue & copied their code for testing |
ericjb
pushed a commit
to ericjb/sktime
that referenced
this pull request
Jul 31, 2025
#### Reference Issues/PRs [ENH] move test skip config from tests._config to estimator tags sktime#8515 #### What does this implement/fix? Explain your changes. This PR implements part of issue sktime#8515 by migrating ResNetClassifier test skip configurations from the central tests._config.py file to the estimator's own tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
[ENH] move test skip config from tests._config to estimator tags #8515
What does this implement/fix? Explain your changes.
This PR implements part of issue #8515 by migrating ResNetClassifier test skip configurations from the central tests._config.py file to the estimator's own tags.