Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Sanchay117
Copy link
Contributor

@Sanchay117 Sanchay117 commented Jul 27, 2025

Fixes #8619

What does this implement/fix? Explain your changes.

I have implemented a test for parallelize where I am running a simple for loop and checking if the results are as expected and ensuring that backend_params is not being mutated.

Does your contribution introduce a new dependency? If yes, which one?

No, it does not.

@fkiraly fkiraly added module:tests test framework functionality - only framework, excl specific tests enhancement Adding new functionality module:base-framework BaseObject, registry, base framework module:plotting&utilities utilities including plottinng labels Jul 27, 2025
@Sanchay117
Copy link
Contributor Author

Hi @fkiraly, copilot is suggesting that the cause of the errors is in ThetaForecaster which isn't related to the test I added. What should I do?

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 2, 2025

@Sanchay117, the reasons for the failures are unclear, but this is probably unrelated.

There is an issue here: #8617

@fkiraly fkiraly changed the title [ENH] Add test for parallelize [ENH] test for parallelize backend abstraction utility Aug 2, 2025
@fkiraly fkiraly changed the title [ENH] test for parallelize backend abstraction utility [ENH] tests for parallelize backend abstraction utility Aug 2, 2025
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Could you add a conditional test skip that ensures that this is only tested when sktime.utils.parallel is changed? Look at other tests, and the utility run_test_module_changed.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we can now merge if tests run through.

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 7, 2025

Failures are unrelated

@fkiraly fkiraly merged commit 16e1708 into sktime:main Aug 7, 2025
60 of 65 checks passed
@github-project-automation github-project-automation bot moved this from PR in progress to Done in May - Sep 2025 mentee projects Aug 7, 2025
@Sanchay117 Sanchay117 deleted the enh/add-simple-test-for-parallelize-8619 branch August 9, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding new functionality module:base-framework BaseObject, registry, base framework module:plotting&utilities utilities including plottinng module:tests test framework functionality - only framework, excl specific tests
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] add test for parallelize, including that the backend_params dict in parallelization is not mutated
2 participants