Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

thisisrick25
Copy link
Contributor

@thisisrick25 thisisrick25 commented Aug 23, 2025

Reference Issues/PRs

Fixes #8703

What does this implement/fix? Explain your changes.

I have modified the test file classification/model_evaluation/tests/test_evaluate.py to test all parallelization backends for the classification evaluate function.

  1. Imported the _get_parallel_test_fixtures utility, which provides a list of available parallel backend configurations.
  2. Used this utility to create a BACKENDS list containing these configurations.
  3. Parameterized the existing test_evaluate_parallel_backend test by adding the @pytest.mark.parametrize("backend", BACKENDS) decorator.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

  • Correctness of the Parameterization
  • Consistency with Existing Patterns

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, for added estimators: I've added myself and possibly to the maintainers tag - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

fkiraly
fkiraly previously approved these changes Aug 23, 2025
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Btw, you would not have needed to close #8736, you could just have updated your branch, that automatically updates the PR.

@thisisrick25
Copy link
Contributor Author

Thank you @fkiraly

#8736 had a lot of code that I was playing with, which would have needed a lot of refactoring.

@fkiraly fkiraly merged commit 2db87b8 into sktime:main Aug 24, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] add tests for TSC evaluate parallelization backends
2 participants