[MNT] Use uv date cutoffs instead of extras for old dependency version testing#9383
[MNT] Use uv date cutoffs instead of extras for old dependency version testing#9383fkiraly wants to merge 1 commit into
uv date cutoffs instead of extras for old dependency version testing#9383Conversation
|
Sorry I didn't actually iterate to ensure this passed CI on a fork. It seems like you'll need an exclusion for It also seems you're affected by pypa/setuptools#5007 in which case you might actually want to keep an exclusion for setuptools just at a later date or otherwise add a constraint. |
|
If removing extras are an option, you can consider this suggestion for dependencies_lowest as well. |
|
@zanieb, thanks for the help! @yarnabrina, I do not understand @zanieb's comment on the |
|
|
I was referring to diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 86ee5495b..685c9a534 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -504,7 +505,10 @@ jobs:
run: python -c "import sys; print(sys.version)"
- name: Install sktime and dependencies
- run: uv pip install .[dev]
+ # setuptools>=78.1.1 is required for sktime itself
+ run: >
+ uv pip install .[dev]
+ --exclude-newer-package 'setuptools=false'
env:
UV_SYSTEM_PYTHON: 1
UV_EXCLUDE_NEWER: "2024-09-01" |
|
I understand this discussion is about the recent ModuleNotFoundError: No module named @zanieb does "--exclude-newer-package 'setuptools=false'" apply only to the main resolution, or does it also affect setuptools resolution inside build isolation for transitive dependencies?
Does |
It affects the entire resolution. |
|
(I'd probably just set it to the date before |
|
superseded by #9383 |
…ncy version testing (#9872) Currently, there are frozen depsets for regression testing time frozen states in 2023 and 2024. This causes issues with `uv sync` and `uv lock` due to `uv`'s universal dependency resolution. Instead, the `UV_EXCLUDE_NEWER` environment variable can be used, which can be used to set a frozen time point for package dependency resolution. Originally created by @zanieb, also see discussion on astral-sh/uv#18026; later in #9383, which was deprecated in favour of this PR. --------- Co-authored-by: Zanie Blue <[email protected]>
#### Reference Issues/PRs Fixes #2054 Related: sktime/sktime#9383 #### What does this implement/fix? Explain your changes. Replaces the explicit dependency set with uv’s UV_EXCLUDE_NEWER to install dependencies from a time-frozen snapshot.
…ncy version testing (sktime#9872) Currently, there are frozen depsets for regression testing time frozen states in 2023 and 2024. This causes issues with `uv sync` and `uv lock` due to `uv`'s universal dependency resolution. Instead, the `UV_EXCLUDE_NEWER` environment variable can be used, which can be used to set a frozen time point for package dependency resolution. Originally created by @zanieb, also see discussion on astral-sh/uv#18026; later in sktime#9383, which was deprecated in favour of this PR. --------- Co-authored-by: Zanie Blue <[email protected]>
…ncy version testing (sktime#9872) Currently, there are frozen depsets for regression testing time frozen states in 2023 and 2024. This causes issues with `uv sync` and `uv lock` due to `uv`'s universal dependency resolution. Instead, the `UV_EXCLUDE_NEWER` environment variable can be used, which can be used to set a frozen time point for package dependency resolution. Originally created by @zanieb, also see discussion on astral-sh/uv#18026; later in sktime#9383, which was deprecated in favour of this PR. --------- Co-authored-by: Zanie Blue <[email protected]>
Currently, there are frozen depsets for regression testing time frozen states in 2023 and 2024.
This causes issues with
uv syncanduv lockdue touv's universal dependency resolution.Instead, the
UV_EXCLUDE_NEWERenvironment variable can be used, which can be used to set a frozen time point for package dependency resolution.Originally created by @zanieb, also see discussion on astral-sh/uv#18026