SK-2286 take vault url from env and override #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyflow-bharti
approved these changes
Sep 9, 2025
saileshwar-skyflow
approved these changes
Sep 9, 2025
skyflow-shravan
added a commit
that referenced
this pull request
Sep 9, 2025
* SK-2286 take vault url from env and override (#223) * SK-2286 take vault url from env and override * SK-2286 add validation for vault url format * SK-2286 add validation for vault url format * [AUTOMATED] Private Release 2.0.0-beta.4-dev-b64524d * SK-2286 throw skyflow exception for empty vault url * SK-2286 add error logs for vault url validations * SK-2286 add error logs for vault url validations * [AUTOMATED] Private Release 2.0.0-beta.4-dev-f012079 --------- Co-authored-by: skyflow-shravan <[email protected]>
skyflow-shravan
added a commit
that referenced
this pull request
Sep 11, 2025
* SK-2286 V3 release/25.9.3 (#224) * SK-2286 take vault url from env and override (#223) * SK-2286 take vault url from env and override * SK-2286 add validation for vault url format * SK-2286 add validation for vault url format * [AUTOMATED] Private Release 2.0.0-beta.4-dev-b64524d * SK-2286 throw skyflow exception for empty vault url * SK-2286 add error logs for vault url validations * SK-2286 add error logs for vault url validations * [AUTOMATED] Private Release 2.0.0-beta.4-dev-f012079 --------- Co-authored-by: skyflow-shravan <[email protected]> * SK-2286 override vault url and accept skyflow creds from env (#225) * SK-2286 accept skyflow creds from system env variables * [AUTOMATED] Private Release 2.0.0-beta.4-dev-4b56b3d --------- Co-authored-by: skyflow-shravan <[email protected]> * SK-2289 Fix upsert operation not working issue * [AUTOMATED] Private Release 2.0.0-beta.4-dev-d3257dc * SK-2289 Update SDK version in constants * [AUTOMATED] Public Release - 3.0.0-beta.4 --------- Co-authored-by: skyflow-shravan <[email protected]> Co-authored-by: skyflow-vivek <[email protected]> Co-authored-by: skyflow-vivek <[email protected]> Co-authored-by: skyflow-vivek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pass vault url from the env variables
Why
Goal
Testing