Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SK-1909 Handle API error cases after fern migration #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

SK-1909 Handle API error cases after fern migration #171

merged 6 commits into from
May 14, 2025

Conversation

@skyflow-vivek
Copy link
Collaborator

@skyflow-vivek skyflow-vivek commented May 2, 2025 •
edited
Loading

This PR contains changes API error cases handling after fern migration for Python SDK v2 as well as some fixes for inconsistencies.

Why

  • The API error cases were not properly handled since we were missing request ids in error responses.
  • These request ids are important part of error structure that helps in troubleshooting and debugging.
  • The invoke connection response structure was inconsistent with other server side SDKs v2.

Goal

  • Proper handling of API error cases in Python SDK v2.
  • Addition of request ids in error responses to help troubleshoot and/or debug any errors.

Testing

  • Manually tested the changes.
  • Modified unit tests to cover all the new changes.

amith-skyflow
amith-skyflow reviewed May 7, 2025
View reviewed changes
@skyflow-vivek
SK-1909 Update fern generated code
f2ce452
@skyflow-vivek
SK-1909 Handle invalid cluster ID error scenario
a9a44d8
@skyflow-vivek
SK-1909 Fix inconsistencies and issues in Python SDK v2
da88042
@skyflow-vivek
SK-1909 Fix issues in Python SDK v2
d79488a 
- Fix inconsistent response structure for invoke connection
- Fix 404 Not found error for get by column values
- Fix failing unit tests due to code changes
@skyflow-vivek skyflow-vivek merged commit 3a80017 into release/25.5.1 May 14, 2025
6 checks passed
@amith-skyflow amith-skyflow deleted the SK-1909-handle-api-error-cases-after-fern-migration branch June 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amith-skyflow amith-skyflow amith-skyflow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyflow-vivek @amith-skyflow