Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: hmr experience #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 17, 2024
Merged

fix: hmr experience #1708

merged 14 commits into from
Jul 17, 2024

Conversation

@kermanx
Copy link
Member

@kermanx kermanx commented Jun 28, 2024 •
edited
Loading

  1. fix: Circular dependency caused flash during HMR
  2. perf: Update preload strategy. Previously, it depended on QuickOverview, now its logic is written in SlidesShow.
  3. fix: no longer pre-mount QuickOverview (i.e. v-if="showOverview" instead of v-show="showOverview")
  4. fix: the last "Preview Next" in presenter mode disappears
  5. fix: clicksContext.onMounted/onUnmounted should be called correctly.

Blocked by vuejs/core#11248

@netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 12067cf
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/6697ceb838bee4000891de49
😎 Deploy Preview https://deploy-preview-1708--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kermanx kermanx marked this pull request as draft June 28, 2024 02:51
@kermanx kermanx marked this pull request as ready for review June 28, 2024 02:58
@kermanx kermanx marked this pull request as draft June 28, 2024 03:54
@kermanx kermanx changed the title fix: circular dependency caused flash during hmr fix: hmr experience Jun 28, 2024
@kermanx kermanx mentioned this pull request Jun 30, 2024
Merged
@kermanx kermanx mentioned this pull request Jul 9, 2024
Merged
@kermanx kermanx removed the upstream label Jul 17, 2024
@kermanx kermanx marked this pull request as ready for review July 17, 2024 13:58
@antfu
Copy link
Member

antfu commented Jul 17, 2024 •
edited
Loading

Do we need to wait until the next Vue patch? I see, it's released in .32

@antfu antfu merged commit d7f4178 into slidevjs:main Jul 17, 2024
This was referenced Aug 31, 2024
Open
Open
Open
Open
This was referenced Sep 5, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kermanx @antfu