Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(breaking): remove attestation-name input and output #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2024
Merged

feat(breaking): remove attestation-name input and output #3456

merged 3 commits into from
Mar 27, 2024

Conversation

ramonpetgrave64
Copy link
Contributor

Summary

Testing Process

  • We have existing PR Check workflows that do call the generic-genertor wth the correct parameters
  • example-package e2e2 tests have already been updated to use the new parameter and are already passing.

Checklist

  • Review the contributing guidelines
  • Add a reference to related issues in the PR description.
  • Update documentation if applicable.
  • Add unit tests if applicable.
  • Add changes to the CHANGELOG if applicable.

@ramonpetgrave64
use provenance-name
6125f0b 
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review March 27, 2024 16:16
@ramonpetgrave64 ramonpetgrave64 changed the title Revert: chore: Revert "fix: remove attestation-name input and output" feat: Revert: chore: Revert "fix: remove attestation-name input and output" Mar 27, 2024
@laurentsimon laurentsimon changed the title feat: Revert: chore: Revert "fix: remove attestation-name input and output" fix: remove attestation-name input and output Mar 27, 2024
@laurentsimon laurentsimon changed the title fix: remove attestation-name input and output feat(breaking): remove attestation-name input and output Mar 27, 2024
laurentsimon
laurentsimon approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@laurentsimon laurentsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@laurentsimon laurentsimon enabled auto-merge (squash) March 27, 2024 16:27
@laurentsimon
Copy link
Collaborator

linter is complaining

@ramonpetgrave64
markdownlint
6001104 
Signed-off-by: Ramon Petgrave <[email protected]>
@laurentsimon laurentsimon merged commit 2512315 into slsa-framework:main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentsimon laurentsimon laurentsimon approved these changes

@joshuagl joshuagl Awaiting requested review from joshuagl

@kpk47 kpk47 Awaiting requested review from kpk47

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] attestation-name deprecation warning [bug] Opaque failure in final step
2 participants
@ramonpetgrave64 @laurentsimon