Slight code speedups #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert indexing operations are in bounds Pull indexing operations out of loops when possible
| end | ||
|
|
||
| function sampleCorpus(model::Model) | ||
| for ii in 1:length(model.corpus) | ||
| sampleDocument(ii, model) | ||
| end | ||
| return |
There was a problem hiding this comment.
Are these just stylistic or do they impact performance in some way?
There was a problem hiding this comment.
Good question: they actually may not impact performance anymore. At one point in the past they could help the compiler from getting confused about the return type of for loops, but that doesn't seem to be true anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the code a bit faster, although it also makes the code a bit uglier.
Basically, there are two types of changes:
@inboundsmacro